-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed bool_to_string()
to return const char*
instead and use it in more cases
#5385
Conversation
556e3df
to
fb5088f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a refactoring and I want to release cppcheck soonish.. so I believe I will not merge this before the release.
gui/projectfile.cpp
Outdated
@@ -857,11 +858,11 @@ bool ProjectFile::write(const QString &filename) | |||
} | |||
|
|||
xmlWriter.writeStartElement(CppcheckXml::CheckHeadersElementName); | |||
xmlWriter.writeCharacters(mCheckHeaders ? "true" : "false"); | |||
xmlWriter.writeCharacters(QString::fromStdString(bool_to_string(mCheckHeaders))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more unnecessary QString::fromStdString here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
No description provided.